Closed eytanadler closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
9dc5d69
) 79.95% compared to head (3c7d7e1
) 79.95%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Purpose
The heat exchanger model previously had an independent variable component connected to most inputs, such as channel geometry, number of channels in each dimension, etc. This prevented users from connecting outputs from other components to these inputs in the heat exchanger model. This fix removes the independent variable component and instead uses OpenMDAO's
set_input_defaults
. This means OpenMDAO will automatically connect anIndepVarComp
with these values if nothing is connected by the user.This change also allows the removal of the copy of all
HXGroup
's internals into the heat exchanger test script.Type of change
What types of change is it? Select the appropriate type(s) that describe this PR
Testing
Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.
Checklist
Put an
x
in the boxes that apply.