mdolab / openconcept

OpenConcept: A toolkit for conceptual MDAO of aircraft with unconventional propulsion architectures
MIT License
36 stars 32 forks source link

Changed Hx Value error to Analysis error for 3 instances. #62

Closed mariejvaucher closed 7 months ago

mariejvaucher commented 8 months ago

Purpose

Previously the script was raising a Python ValueError that wasn't caught by OM solvers. Now the error is an OM Analysis Error which allows the solver to continue optimization and also gives details about which value is wrong and why.

Type of change

Testing

Added new tests

Checklist

Put an x in the boxes that apply.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.98%. Comparing base (773de3a) to head (32d4897).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #62 +/- ## ========================================== + Coverage 79.95% 79.98% +0.03% ========================================== Files 85 85 Lines 9300 9300 ========================================== + Hits 7436 7439 +3 + Misses 1864 1861 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.