mdolab / openconcept

OpenConcept: A toolkit for conceptual MDAO of aircraft with unconventional propulsion architectures
MIT License
37 stars 32 forks source link

Major refactoring #9

Closed bbrelje closed 5 years ago

bbrelje commented 5 years ago

Refactored basically everything to simplify the structure of the aircraft run scripts. Aircraft are coming out identical, unit tests are passing.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 75


Changes Missing Coverage Covered Lines Changed/Added Lines %
openconcept/utilities/nodes.py 1 7 14.29%
openconcept/analysis/takeoff.py 5 139 3.6%
openconcept/analysis/mission.py 37 409 9.05%
<!-- Total: 43 555 7.75% -->
Files with Coverage Reduction New Missed Lines %
openconcept/analysis/takeoff.py 2 12.13%
openconcept/analysis/mission.py 3 12.78%
<!-- Total: 5 -->
Totals Coverage Status
Change from base Build 65: -2.2%
Covered Lines: 1076
Relevant Lines: 2463

💛 - Coveralls
bbrelje commented 5 years ago

This PR is a breaking change but major improvement from the initial summer release. As there are no other known users yet I don't foresee any issues. Script conversion is straightforward and answers are identical.