mdolab / pygeo

pyGeo provides geometric design variables and constraints suitable for gradient-based optimization.
https://mdolab-pygeo.readthedocs-hosted.com/en/latest/?badge=latest
Apache License 2.0
131 stars 55 forks source link

Several changes to demoDesignVars #104

Closed sseraj closed 3 years ago

sseraj commented 3 years ago

Purpose

I made several changes to demoDesignVars, mainly:

Type of change

Testing

In your optimization script, before running the optimizer, put something like the following lines:

CFDSolver.setAeroProblem(ap)
DVGeo.demoDesignVars(outDir, CFDSolver=CFDSolver)

Checklist

codecov[bot] commented 3 years ago

Codecov Report

Merging #104 (ab00203) into master (435d7ad) will increase coverage by 0.67%. The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   59.48%   60.16%   +0.67%     
==========================================
  Files          40       40              
  Lines        9614     9617       +3     
==========================================
+ Hits         5719     5786      +67     
+ Misses       3895     3831      -64     
Impacted Files Coverage Δ
pygeo/parameterization/DVGeo.py 65.51% <72.22%> (+3.41%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 435d7ad...ab00203. Read the comment docs.

sseraj commented 3 years ago

We don't want to test this with a CFDSolver instance... maybe we can add that test to the MACH-Aero tutorial?

Right, I didn't want to introduce ADflow as a testing dependency. Given that this only tests the files created, I don't see much benefit in testing this in MACH-Aero.