Closed sseraj closed 3 years ago
Merging #104 (ab00203) into master (435d7ad) will increase coverage by
0.67%
. The diff coverage is72.22%
.
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
+ Coverage 59.48% 60.16% +0.67%
==========================================
Files 40 40
Lines 9614 9617 +3
==========================================
+ Hits 5719 5786 +67
+ Misses 3895 3831 -64
Impacted Files | Coverage Δ | |
---|---|---|
pygeo/parameterization/DVGeo.py | 65.51% <72.22%> (+3.41%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 435d7ad...ab00203. Read the comment docs.
We don't want to test this with a CFDSolver instance... maybe we can add that test to the
MACH-Aero
tutorial?
Right, I didn't want to introduce ADflow as a testing dependency. Given that this only tests the files created, I don't see much benefit in testing this in MACH-Aero.
Purpose
I made several changes to demoDesignVars, mainly:
upper
variable. The function now works if a parent FFD has no DVs.Type of change
Testing
In your optimization script, before running the optimizer, put something like the following lines:
Checklist
flake8
andblack
to make sure the code adheres to PEP-8 and is consistently formatted