mdolab / pygeo

pyGeo provides geometric design variables and constraints suitable for gradient-based optimization.
https://mdolab-pygeo.readthedocs-hosted.com/en/latest/?badge=latest
Apache License 2.0
124 stars 55 forks source link

writeRefAxes fix for Python 3 #107

Closed sseraj closed 2 years ago

sseraj commented 2 years ago

Purpose

.keys() in Python 3 does not return a list, so writeRefAxes has been broken.

Type of change

Testing

I added a test that just checks if files have been written.

Checklist

codecov[bot] commented 2 years ago

Codecov Report

Merging #107 (6819946) into master (8e0c217) will increase coverage by 0.23%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage   60.38%   60.62%   +0.23%     
==========================================
  Files          40       40              
  Lines        9764     9764              
==========================================
+ Hits         5896     5919      +23     
+ Misses       3868     3845      -23     
Impacted Files Coverage Δ
pygeo/parameterization/DVGeo.py 65.36% <100.00%> (+0.36%) :arrow_up:
pygeo/pyNetwork.py 61.07% <0.00%> (+10.73%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8e0c217...6819946. Read the comment docs.

marcomangano commented 2 years ago

Does this address https://github.com/mdolab/pygeo/issues/69 ?

sseraj commented 2 years ago

Does this address #69 ?

Yes, thanks for catching that.