eirikurj commented 2 years ago

Purpose

Tests are failing due to recent changes in API.

Update API for DVGeoESP, DVGeoVSP, DVGeoMulti with similar changes as done in https://github.com/mdolab/pygeo/pull/119

Its possible that other things need to be updated but are not tested. As is, the option for these functions is not particularly useful.

Expected time until merged

End of week

Type of change

[x] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (non-backwards-compatible fix or feature)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Documentation update
[ ] Maintenance update
[ ] Other (please describe)

Testing

Checklist

[ ] I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
[ ] I have run unit and regression tests which pass locally with my changes
[ ] I have added new tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation

codecov[bot] commented 2 years ago

Codecov Report

Merging #124 (47c6ac3) into master (740a4c0) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   63.40%   63.40%           
=======================================
  Files          41       41           
  Lines       11033    11033           
=======================================
  Hits         6995     6995           
  Misses       4038     4038

Impacted Files	Coverage Δ
pygeo/parameterization/DVGeoESP.py	`65.48% <100.00%> (ø)`
pygeo/parameterization/DVGeoMulti.py	`89.82% <100.00%> (ø)`
pygeo/parameterization/DVGeoVSP.py	`81.25% <100.00%> (ø)`

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

ewu63 commented 2 years ago

Thanks for the PR @eirikurj. In the future, we probably want to refactor this to have an abstractbaseDVGeo class with a well-defined API.

mdolab / pygeo

Add composite DVs - part 2 #124