mdolab / pygeo

pyGeo provides geometric design variables and constraints suitable for gradient-based optimization.
https://mdolab-pygeo.readthedocs-hosted.com/en/latest/?badge=latest
Apache License 2.0
131 stars 55 forks source link

Point set kwargs for DVGeometryMulti #154

Closed sseraj closed 2 years ago

sseraj commented 2 years ago

Purpose

I made two changes related to addPointSet kwargs for DVGeometryMulti: 1) Added an option to pass kwargs for the triangulated surface mesh 2) Pass kwargs from DVGeometryMulti's addPointSet to the component addPointSet

I also changed mutable default assignments to be inside functions. These were not causing any issues to my knowledge, but this should be safer.

Expected time until merged

1 week

Type of change

Testing

Checklist

codecov[bot] commented 2 years ago

Codecov Report

Merging #154 (4ceb66c) into main (787a96d) will increase coverage by 0.00%. The diff coverage is 73.33%.

@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage   63.89%   63.90%           
=======================================
  Files          47       47           
  Lines       11745    11757   +12     
=======================================
+ Hits         7505     7513    +8     
- Misses       4240     4244    +4     
Impacted Files Coverage Δ
pygeo/parameterization/DVGeoMulti.py 89.77% <73.33%> (-0.23%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more