search

mdolab / pygeo

pyGeo provides geometric design variables and constraints suitable for gradient-based optimization.
https://mdolab-pygeo.readthedocs-hosted.com/en/latest/?badge=latest
Apache License 2.0
124 stars 55 forks source link

Remove the duplicate tolerance when embedding points. #158

Open anilyil opened 1 year ago

anilyil commented 1 year ago

Description of feature

Once the PR https://github.com/mdolab/pyspline/pull/47 is merged, the pyspline projection will use the same tolerance used to check if a point is inside the volume or not. With this change, we can remove the additional embTol in the attachPoints method in pyBlock: https://github.com/mdolab/pygeo/blob/main/pygeo/pyBlock.py#L775

Potential solution

We can default to just using eps both in the projection solver and for checking if a point successfully projected or not.

KapilKhanal commented 12 months ago

Please remove if this is not relevant to the discussion here. @anilyil is there a way to change that tolerance? I keep getting this error " Warning: 2304 point(s) not projected to tolerance: 1e-12. Max Error: 0.5 ; RMS Error: 0.20729" for a 3D cylinder like object created custom. I could not find if there are some workaround for this. Thanks!