mdolab / pygeo

pyGeo provides geometric design variables and constraints suitable for gradient-based optimization.
https://mdolab-pygeo.readthedocs-hosted.com/en/latest/?badge=latest
Apache License 2.0
131 stars 55 forks source link

Update README.md #164

Closed hajdik closed 1 year ago

hajdik commented 2 years ago

Purpose

The readme didn't have all the parameterization options or the right year

Expected time until merged

fast

Type of change

Checklist

codecov[bot] commented 2 years ago

Codecov Report

Merging #164 (a941087) into main (2905061) will decrease coverage by 0.00%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
- Coverage   63.93%   63.92%   -0.01%     
==========================================
  Files          47       47              
  Lines       11819    11818       -1     
==========================================
- Hits         7556     7555       -1     
  Misses       4263     4263              
Impacted Files Coverage Δ
pygeo/constraints/baseConstraint.py 57.22% <ø> (-0.24%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

marcomangano commented 2 years ago

It looks like we need to pin one of flake8 sub packages?

ewu63 commented 2 years ago

It's a valid complaint, I think we should probably fix it.

marcomangano commented 1 year ago

How are we taking care of the flake8 fixes?

sseraj commented 1 year ago

I removed addVariablesPyOpt from baseConstraint because only ColinearityConstraint implements this method (which makes sense because most constraints don't have their own DVs).