Closed sseraj closed 1 year ago
Haha, great timing @sseraj, just wrote an issue (see https://github.com/mdolab/pygeo/issues/178) for this and was about this push a fix. Thanks for taking care of this.
Merging #177 (904ddfa) into main (0e67ef4) will increase coverage by
3.98%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #177 +/- ##
==========================================
+ Coverage 60.63% 64.61% +3.98%
==========================================
Files 47 47
Lines 11954 11954
==========================================
+ Hits 7248 7724 +476
+ Misses 4706 4230 -476
Impacted Files | Coverage Δ | |
---|---|---|
pygeo/parameterization/DVGeoSketch.py | 68.22% <0.00%> (+0.93%) |
:arrow_up: |
pygeo/parameterization/designVars.py | 79.25% <0.00%> (+4.25%) |
:arrow_up: |
pygeo/parameterization/DVGeoESP.py | 66.29% <0.00%> (+65.31%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Purpose
I removed unnecessary test skipping in the FFD and ESP tests introduced in #170. I also split up the VSP test classes so that the wing tests are not parameterized, avoiding the need to skip the parallel tests. It seems like the wing tests might work in parallel now, but I will leave it to someone who uses VSP to verify this and enable the parallel tests in a future PR.
Finally, I switched the Docker image used by Azure to public and removed the check for private images in the test command because the public images have all the required dependencies now.
Closes #178
Expected time until merged
ASAP because the buildbot is broken
Type of change
Testing
All tests should pass on Azure with no skipped tests.
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable