Open ArshSaja opened 1 year ago
Merging #181 (706585c) into main (94909eb) will decrease coverage by
0.01%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## main #181 +/- ##
==========================================
- Coverage 64.61% 64.60% -0.01%
==========================================
Files 47 47
Lines 11954 11952 -2
==========================================
- Hits 7724 7722 -2
Misses 4230 4230
Impacted Files | Coverage Δ | |
---|---|---|
pygeo/mphys/mphys_dvgeo.py | 0.00% <ø> (ø) |
|
pygeo/parameterization/DVGeoSketch.py | 67.92% <ø> (-0.30%) |
:arrow_down: |
pygeo/parameterization/DVGeoVSP.py | 81.50% <ø> (-0.05%) |
:arrow_down: |
pygeo/pyBlock.py | 46.92% <0.00%> (-0.10%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Please see my comments in #179
What is the status of this PR? @ArshSaja are you going to address @anilyil comments about additional checks?
@marcomangano Yes, I am planning to address them next week or so.. probably I will get it done soon
@ArshSaja any updates on this?
@ArshSaja any updates on this?
I made some changes. I will push them soon when it is finalized.
Purpose
DvGeo prints a warning when it cannot embed points. So that people understand not to proceed, this warning has to be strengthened. This PR will assist in identifying any such problems.
Expected time until merged
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable