Closed eytanadler closed 1 year ago
Merging #182 (11ae74b) into main (cc5c642) will not change coverage. The diff coverage is
0.00%
.
@@ Coverage Diff @@
## main #182 +/- ##
=======================================
Coverage 64.76% 64.76%
=======================================
Files 47 47
Lines 11949 11949
=======================================
Hits 7739 7739
Misses 4210 4210
Impacted Files | Coverage Δ | |
---|---|---|
pygeo/constraints/DVCon.py | 71.72% <ø> (ø) |
|
pygeo/constraints/baseConstraint.py | 57.22% <ø> (ø) |
|
pygeo/constraints/gearPostConstraint.py | 16.36% <ø> (ø) |
|
pygeo/geo_utils/dcel.py | 11.30% <ø> (ø) |
|
pygeo/geo_utils/ffd_generation.py | 83.89% <ø> (ø) |
|
pygeo/geo_utils/node_edge_face.py | 45.71% <ø> (ø) |
|
pygeo/geo_utils/pointselect.py | 7.14% <ø> (ø) |
|
pygeo/geo_utils/projection.py | 17.76% <ø> (ø) |
|
pygeo/geo_utils/split_quad.py | 7.31% <ø> (ø) |
|
pygeo/mphys/mphys_dvgeo.py | 0.00% <ø> (ø) |
|
... and 10 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Purpose
In very specific cases in GitHub Action builds for OpenAeroStruct, the matplotlib import was failing because of something in the font manager. With a brief effort, I was not able to reproduce it locally. One case that fails on GitHub Actions is with Python 3.8 (seems to be fixed in Python 3.10 and beyond) and the following Python package versions:
The error raised when pytest is then called is:
By catching the ImportError instead of only if matplotlib is not installed, this problem is caught. The error may have something to do with https://github.com/matplotlib/matplotlib/issues/19560.
Type of change