mdolab / pygeo

pyGeo provides geometric design variables and constraints suitable for gradient-based optimization.
https://mdolab-pygeo.readthedocs-hosted.com/en/latest/?badge=latest
Apache License 2.0
124 stars 55 forks source link

Fix scipy factorized import #185

Closed A-CGray closed 1 year ago

A-CGray commented 1 year ago

Purpose

SciPy has started producing the following deprecation warnings when running pyGeo:

DeprecationWarning: Please use `factorized` from the `scipy.sparse.linalg` namespace, the `scipy.sparse.linalg.eigen` namespace is deprecated.

This PR updates where we get the factorized function from to fix this. I checked, and the factorized function is available in the new location in scipy 1.5.4 which is the oldest version we currently we support.

Exactly the same as https://github.com/mdolab/pyspline/pull/53

Expected time until merged

1 day

Type of change

Testing

Checklist

sseraj commented 1 year ago

Can you also fix this is pyBlock.fitGlobal ?

codecov[bot] commented 1 year ago

Codecov Report

Merging #185 (87dd700) into main (8e6ba8a) will not change coverage. The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage   64.76%   64.76%           
=======================================
  Files          47       47           
  Lines       11949    11949           
=======================================
  Hits         7739     7739           
  Misses       4210     4210           
Impacted Files Coverage Δ
pygeo/pyBlock.py 47.87% <0.00%> (ø)
pygeo/pyGeo.py 39.71% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more