Add triangulated surface constraint to MPhys wrapper

hajdik commented 1 year ago

Purpose

This adds TriangulatedSurfaceConstraint to mphys_dvgeo so packaging constraints (GeoGrad) can be used in MPhys and cleans up a few things related to that constraint in DVCon. The GeoGrad fail flag, which skips CFD if the intersection between the two objects exceeds the tolerance, has also been exposed to the MPhys wrapper using OpenMDAO'sAnalysisError. The parallelism fix in #191 was also done for this constraint. Unrelated to this constraint, a few missing options were added into existing constraints in the MPhys wrapper.

Expected time until merged

1 week

Type of change

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (non-backwards-compatible fix or feature)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Documentation update
[ ] Maintenance update
[ ] Other (please describe)

Testing

I have a runscript modified from an old MACH runscript that runs as expected with MPhys in place of MACH. If someone wants to use it in a docker container I can pass that and the input files along.

Checklist

[x] I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
[ ] I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
[x] I have run unit and regression tests which pass locally with my changes
[ ] I have added new tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation

codecov[bot] commented 1 year ago

Codecov Report

Merging #192 (11f05db) into main (7c743d8) will decrease coverage by 0.04%. The diff coverage is 5.55%.

@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
- Coverage   64.79%   64.75%   -0.04%     
==========================================
  Files          47       47              
  Lines       11957    11964       +7     
==========================================
  Hits         7747     7747              
- Misses       4210     4217       +7

Impacted Files	Coverage Δ
pygeo/constraints/DVCon.py	`71.72% <ø> (ø)`
pygeo/mphys/mphys_dvgeo.py	`0.00% <0.00%> (ø)`
pygeo/constraints/areaConstraint.py	`75.91% <33.33%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

eytanadler commented 1 year ago

LGTM

bernardopacini commented 1 year ago

I am good with this, though I cam not a pyGeo maintainer so I cannot merge it. Whoever is (@mdolab/pygeo_maintainers), please go ahead and merge this in.

mdolab / pygeo