New functions in MPhys wrapper

hajdik commented 1 year ago

Purpose

Adding addLocalSectionDVs to the MPhys wrapper and adding ways to return the geometry component's DVCon and DVGeo (or child DVGeo) objects so the user can use each class's methods directly

Expected time until merged

2 months

Type of change

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (non-backwards-compatible fix or feature)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Documentation update
[ ] Maintenance update
[ ] Other (please describe)

Testing

soon

Checklist

[x] I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
[ ] I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
[x] I have run unit and regression tests which pass locally with my changes
[ ] I have added new tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation

codecov[bot] commented 1 year ago

Codecov Report

Merging #193 (9e7bf7c) into main (52ebeaf) will decrease coverage by 0.09%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   64.87%   64.78%   -0.09%     
==========================================
  Files          47       47              
  Lines       11953    11969      +16     
==========================================
  Hits         7754     7754              
- Misses       4199     4215      +16

Impacted Files	Coverage Δ
pygeo/mphys/mphys_dvgeo.py	`0.00% <0.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

hajdik commented 1 year ago

Lucas is testing this with his case, don't merge until we double check that it's good there.

hajdik commented 1 year ago

I added other functions I've been needing in MPhys to this PR and updated the info. Lucas said local shape variables have been working for him so I think everything is good to go.

hajdik commented 1 year ago

This PR is still ready for review and now has docstrings, by popular demand.

bernardopacini commented 1 year ago

From today's maintenance meeting, we decided to remove methods from the MPhys wrapper that do not add input / outputs for OpenMDAO (with the exception of adding a reference axis). Instead, we should add a method that just returns the DVGeo object so the user can directly interface with the underlying object methods.

hajdik commented 1 year ago

From today's maintenance meeting, we decided to remove methods from the MPhys wrapper that do not add input / outputs for OpenMDAO (with the exception of adding a reference axis). Instead, we should add a method that just returns the DVGeo object so the user can directly interface with the underlying object methods.

These changes have been addressed.

mdolab / pygeo