mdolab / pygeo

pyGeo provides geometric design variables and constraints suitable for gradient-based optimization.
https://mdolab-pygeo.readthedocs-hosted.com/en/latest/?badge=latest
Apache License 2.0
122 stars 54 forks source link

Reduce tolerance on tests to support Mac ARM #195

Closed eirikurj closed 1 year ago

eirikurj commented 1 year ago

Purpose

This PR reduces the tolerance on few tests to get tests on the ARM based Mac Mini to pass (see https://github.com/mdolab/docker/pull/170#issuecomment-1511253227 for more details).

Expected time until merged

No rush, but needed for https://github.com/mdolab/docker/pull/170

Type of change

Testing

Run tests. Users with M1 or M2 CPUs should test this without and with the patch.

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #195 (a356614) into main (7ca8f36) will increase coverage by 0.00%. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #195   +/-   ##
=======================================
  Coverage   64.87%   64.88%           
=======================================
  Files          47       47           
  Lines       11941    11942    +1     
=======================================
+ Hits         7747     7748    +1     
  Misses       4194     4194           

see 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

anilyil commented 1 year ago

Created a PR that fixes this discrepancy here: https://github.com/mdolab/pygeo/pull/199 closing this PR because the changes should not be needed anymore.