Closed eirikurj closed 1 year ago
Merging #197 (8c5a697) into main (f6a44b1) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #197 +/- ##
=======================================
Coverage 64.87% 64.87%
=======================================
Files 47 47
Lines 11941 11941
=======================================
Hits 7747 7747
Misses 4194 4194
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
TACC image failed before because previously the OS
variable was not set on this image, thus skipped test are allowed. ESP is not installed because of an Intel MPI check when building the docker images. To be consistent, I added I_MPI_ROOT
check also for Intel MPI. Should be good now, but I any case we should get ESP/OpenVSP integrated on Intel.
Purpose
New Intel Ubuntu docker images do not have ESP and OpenVSP installed, resulting in the tests failing, as no tests are allowed to skip (see https://github.com/mdolab/docker/pull/193). This PR updated the check to the compiler instead of the OS.
Expected time until merged
Should be quick once tests pass.
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable