change extra flags test check to compiler

eirikurj commented 1 year ago

Purpose

New Intel Ubuntu docker images do not have ESP and OpenVSP installed, resulting in the tests failing, as no tests are allowed to skip (see https://github.com/mdolab/docker/pull/193). This PR updated the check to the compiler instead of the OS.

Expected time until merged

Should be quick once tests pass.

Type of change

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (non-backwards-compatible fix or feature)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Documentation update
[x] Maintenance update
[ ] Other (please describe)

Testing

Checklist

[ ] I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
[ ] I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
[ ] I have run unit and regression tests which pass locally with my changes
[ ] I have added new tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation

codecov[bot] commented 1 year ago

Codecov Report

Merging #197 (8c5a697) into main (f6a44b1) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   64.87%   64.87%           
=======================================
  Files          47       47           
  Lines       11941    11941           
=======================================
  Hits         7747     7747           
  Misses       4194     4194

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

eirikurj commented 1 year ago

TACC image failed before because previously the OS variable was not set on this image, thus skipped test are allowed. ESP is not installed because of an Intel MPI check when building the docker images. To be consistent, I added I_MPI_ROOT check also for Intel MPI. Should be good now, but I any case we should get ESP/OpenVSP integrated on Intel.

mdolab / pygeo