Closed timryanb closed 1 year ago
Merging #198 (3b3418c) into main (b7138ab) will increase coverage by
0.00%
. The diff coverage is75.00%
.
@@ Coverage Diff @@
## main #198 +/- ##
=======================================
Coverage 64.86% 64.86%
=======================================
Files 47 47
Lines 11944 11952 +8
=======================================
+ Hits 7747 7753 +6
- Misses 4197 4199 +2
Impacted Files | Coverage Δ | |
---|---|---|
pygeo/parameterization/DVGeoVSP.py | 81.97% <75.00%> (-0.09%) |
:arrow_down: |
... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
This looks good to me. @ArshSaja or someone who uses VSP more do we want to update the version of VSP we use in the Docker images? We currently use 3.28
Simple answer, yes I think we should update VSP in the Docker images.
Purpose
A backwards-incompatible change has been introduced in OpenVSP starting with version 3.33.0 (see release notes here). This change affects the scaling of one of the parameter coordinates used in OpenVSP's volume parameterization. The fix to this is pretty straight-forward on the pyGeo side: include a conditional scale factor on the affected coordinate depending on which OpenVSP version is installed.
Expected time until merged
1 week
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable