mdolab / pygeo

pyGeo provides geometric design variables and constraints suitable for gradient-based optimization.
https://mdolab-pygeo.readthedocs-hosted.com/en/latest/?badge=latest
Apache License 2.0
122 stars 54 forks source link

DVGeoESP compatibility with ESP 122 #213

Closed hajdik closed 1 year ago

hajdik commented 1 year ago

Purpose

The docker images are being updated from ESP 120 to 122, which is required by TACS for the TACS-CAPS interface. Some of the ESP tests failed due to a minor UI change in ESP's python wrapper. The GCC images on that PR will keep failing until this is merged.

Expected time until merged

Depends on which PR we want to merge first

Type of change

Testing

I have a local docker image with new ESP and this branch and the pyGeo tests pass. I'm not sure if this will pass with the old ESP

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #213 (470147f) into main (dc41b1f) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #213   +/-   ##
=======================================
  Coverage   64.76%   64.76%           
=======================================
  Files          47       47           
  Lines       12018    12018           
=======================================
  Hits         7784     7784           
  Misses       4234     4234           
Impacted Files Coverage Δ
pygeo/parameterization/DVGeoESP.py 66.57% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more