mdolab / pygeo

pyGeo provides geometric design variables and constraints suitable for gradient-based optimization.
https://mdolab-pygeo.readthedocs-hosted.com/en/latest/?badge=latest
Apache License 2.0
122 stars 54 forks source link

Volume projection bounds #221

Closed anilyil closed 11 months ago

anilyil commented 11 months ago

Purpose

This PR adds the capability to set parametric bounds in the embedding volume of each FFD box. This is useful to control the behavior of overlapping FFDs, where the user wants to avoid embedding any point in one portion of one or both of the FFDs.

This PR needs changes in https://github.com/mdolab/pyspline/pull/63 to work.

Expected time until merged

After https://github.com/mdolab/pyspline/pull/63 is merged.

Type of change

Testing

Checklist

hajdik commented 11 months ago

I can't merge it with the failures, @anilyil can you do it?

sseraj commented 11 months ago

Did anyone actually run this on Azure? The tests are failing

anilyil commented 11 months ago

I am on it. That previous run was probably not right

lamkina commented 11 months ago

Did anyone actually run this on Azure? The tests are failing

We tried to manually run an Azure and accidentally ran the wrong PR and didn't realize it.

sseraj commented 11 months ago

Ah okay, I see that manual run. For future reference, the checks in PRs should be updated even if you manually run the pipeline (as long as it's the correct commit).