Closed bernardopacini closed 7 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
e47a454
) 65.04% compared to head (61ca21f
) 65.18%.
Files | Patch % | Lines |
---|---|---|
pygeo/parameterization/DVGeoMulti.py | 95.45% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I added a test for the sliding curve feature as discussed offline with @hajdik and @sseraj. It checks to ensure that a few points remain on the lines on which they were defined, but allowed to vary along them (@anilyil let me know if it is okay with you too).
Thanks for the feedback @sseraj! I updated the files with your comments and defer to @anilyil on the implementation-specific comments.
@sseraj, I addressed both of your comments. Also, thank you for spelling out pretty much all of the changes needed in the comments. Both things you said are correct. Please review my changes and mark the conversations as resolved.
@bernardopacini, this PR is good for another round of reviews, correct?
@sseraj, I addressed both of your comments. Also, thank you for spelling out pretty much all of the changes needed in the comments. Both things you said are correct. Please review my changes and mark the conversations as resolved.
@bernardopacini, this PR is good for another round of reviews, correct?
I just updated the assertions as recommended by @sseraj, now should be good to go.
Purpose
There are cases when using the intersection method in which a curve on a surface should be preserved to make sure that the patch does not change size or the curve is maintained to a certain shape. For example, maintaining the interface line between a propeller hub and nacelle is important to ensure a realistic boundary condition on each patch. This PR adds this sort of tracking.
These changes are actually made by @anilyil.
Expected time until merged
2 weeks.
Type of change
Testing
I have run this locally and also checked the derivatives to make sure the code is correct.
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable