mdolab / pygeo

pyGeo provides geometric design variables and constraints suitable for gradient-based optimization.
https://mdolab-pygeo.readthedocs-hosted.com/en/latest/?badge=latest
Apache License 2.0
122 stars 54 forks source link

Fixed LE radius projection #235

Closed sseraj closed 7 months ago

sseraj commented 7 months ago

Purpose

The projection to the leading edge for the LE radius constraint currently projects points to the LE and TE even though only the LE point is used. @bernardopacini found that the TE projection can sometimes fail. Following @anilyil's suggestion, I changed the projection to only project to the LE.

Expected time until merged

1 week

Type of change

Testing

The existing LE radius constraint tests pass.

Checklist

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9bbcdf0) 65.18% compared to head (4d577f5) 65.30%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #235 +/- ## ========================================== + Coverage 65.18% 65.30% +0.12% ========================================== Files 47 47 Lines 12123 12122 -1 ========================================== + Hits 7902 7916 +14 + Misses 4221 4206 -15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.