Fix spanwise Local DV offset

joanibal commented 4 months ago

Purpose

The title says it all. It's a small fix for cases where you have spanwiseLocalDV and other variables. Right now, self.nDVSW_count defaults to 0 causing it to overwrite other columns of the Jacobian.

Expected time until merged

1 week

Type of change

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (non-backwards-compatible fix or feature)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Documentation update
[ ] Maintenance update
[ ] Other (please describe)

Checklist

[ ] I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
[ ] I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
[ ] I have run unit and regression tests which pass locally with my changes
[ ] I have added new tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation

joanibal commented 4 months ago

I don't think the failing docs are my fault

Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/mdolab-pygeo/envs/243/lib/python3.11/site-packages/sphinx/cmd/build.py", line 332, in build_main
    app = Sphinx(args.sourcedir, args.confdir, args.outputdir,
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/docs/checkouts/readthedocs.org/user_builds/mdolab-pygeo/envs/243/lib/python3.11/site-packages/sphinx/application.py", line 268, in __init__
    self._init_builder()
  File "/home/docs/checkouts/readthedocs.org/user_builds/mdolab-pygeo/envs/243/lib/python3.11/site-packages/sphinx/application.py", line 338, in _init_builder
    self.builder.init()
  File "/home/docs/checkouts/readthedocs.org/user_builds/mdolab-pygeo/envs/243/lib/python3.11/site-packages/sphinx/builders/html/__init__.py", line 228, in init
    self.init_templates()
  File "/home/docs/checkouts/readthedocs.org/user_builds/mdolab-pygeo/envs/243/lib/python3.11/site-packages/sphinx/builders/html/__init__.py", line 278, in init_templates
    self.theme = theme_factory.create(theme_name)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/docs/checkouts/readthedocs.org/user_builds/mdolab-pygeo/envs/243/lib/python3.11/site-packages/sphinx/theming.py", line 228, in create
    themes, theme_dirs, tmp_dirs = _load_theme_with_ancestors(self._themes, name)
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/docs/checkouts/readthedocs.org/user_builds/mdolab-pygeo/envs/243/lib/python3.11/site-packages/sphinx/theming.py", line 266, in _load_theme_with_ancestors
    raise ThemeError(msg)
sphinx.errors.ThemeError: The 'sphinx_mdolab_theme' theme inherits from 'sphinx_rtd_theme', which is not a loaded theme. Loaded themes are: agogo, alabaster, basic, bizstyle, classic, default, epub, haiku, nature, nonav, pyramid, scrolls, sphinx_mdolab_theme, sphinxdoc, traditional

Theme error:
The 'sphinx_mdolab_theme' theme inherits from 'sphinx_rtd_theme', which is not a loaded theme. Loaded themes are: agogo, alabaster, basic, bizstyle, classic, default, epub, haiku, nature, nonav, pyramid, scrolls, sphinx_mdolab_theme, sphinxdoc, traditional

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.46%. Comparing base (ad9338a) to head (7d1a475).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #243 +/- ## ======================================= Coverage 65.46% 65.46% ======================================= Files 47 47 Lines 12265 12266 +1 ======================================= + Hits 8029 8030 +1 Misses 4236 4236 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

eirikurj commented 4 months ago

@joanibal docs build failed due to recent sphinx updates, which are now patched. For some reason, the intel build timed out, but restarting seems to have fixed it.

mdolab / pygeo