Closed A-CGray closed 2 weeks ago
Attention: Patch coverage is 91.83673%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 65.41%. Comparing base (
3070c1a
) to head (8d199ad
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
pygeo/constraints/DVCon.py | 73.33% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The changes make sense, but I wonder if it is more elegant to have something like:
if nDV == 0:
pass
The changes make sense, but I wonder if it is more elegant to have something like:
if nDV == 0: pass
I don't think it matters, this solution would be 1 line longer than what's currently there.
@eytanadler so glad we figured this out so now you and @hajdik can get the mphys tests working :)
Purpose
The
evalFunctionsSens
method of the projected area constraint currently fails if it is called when there are no geometric design variables because only the creation of the dAp0/1/2 arrays are skipped, but the rest of the function, that uses those arrays, is not. This is fixed by simply skipping everything ifnDV ==0
.Also:
np.random.seed
andnp.random.rand
tonp.random.default_rng
andrng.random
Expected time until merged
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable