mdolab / pygeo

pyGeo provides geometric design variables and constraints suitable for gradient-based optimization.
https://mdolab-pygeo.readthedocs-hosted.com/en/latest/?badge=latest
Apache License 2.0
124 stars 55 forks source link

Added return value back to deprecated function calls #96

Closed joanibal closed 3 years ago

joanibal commented 3 years ago

Purpose

The return value needs to be passed through the deprecated function calls, because some scripts use the return value.

Type of change

What types of change is it? Select the appropriate type(s) that describe this PR

Checklist

Put an x in the boxes that apply.

ewu63 commented 3 years ago

@joanibal we had restructured the repo recently, so instead of resolving the merge conflict it may be easier to just redo the commit again after pulling the latest changes.

codecov[bot] commented 3 years ago

Codecov Report

Merging #96 (a496665) into master (fd4b04d) will decrease coverage by 9.88%. The diff coverage is 0.00%.

:exclamation: Current head a496665 differs from pull request most recent head b3f5d85. Consider uploading reports for the commit b3f5d85 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
- Coverage   51.12%   41.23%   -9.89%     
==========================================
  Files          38       38              
  Lines        9571     9571              
==========================================
- Hits         4893     3947     -946     
- Misses       4678     5624     +946     
Impacted Files Coverage Δ
pygeo/parameterization/DVGeo.py 61.76% <0.00%> (-0.37%) :arrow_down:
pygeo/parameterization/DVGeometryVSP.py 2.90% <0.00%> (-78.13%) :arrow_down:
pygeo/DVGeometryESP.py 0.00% <0.00%> (-65.49%) :arrow_down:
pygeo/constraints/areaConstraint.py 52.51% <0.00%> (-26.11%) :arrow_down:
pygeo/constraints/DVCon.py 58.71% <0.00%> (-3.58%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fd4b04d...b3f5d85. Read the comment docs.