Fixed tests hanging under Intel/Centos image

[ewu63]

Purpose

I couldn't really figure out why the tests were hanging. I tried different variants of subprocess.run, on one proc and on both, nothing worked. But somehow the reliable os.system worked just fine, so I used a workaround to pipe the output to a file, and read it back in. Hacky but works. I also changed it so cgnsdiff is called only on the root proc, and the results are bcast to everything.

As a somewhat unrelated change, I updated setup.py so that it's no longer installing all packages under the root directory when installing in editable mode. We should probably change this for all other packages. To explain this a bit better: Previously, when installing with pip install -e ., if you then run the following

cd ~
python -c "import examples; print(examples.__path__)"

you should get <path-to-pyhyp>/examples, meaning you now magically have a Python package called examples. With the changes in this PR, this is no longer the case.

Type of change

• [x] Bugfix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (non-backwards-compatible fix or feature)
• [ ] Code style update (formatting, renaming)
• [ ] Refactoring (no functional changes, no API changes)
• [ ] Documentation update
• [ ] Maintenance update
• [ ] Other (please describe)

Testing

Checklist

• [x] I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
• [x] I have run unit and regression tests which pass locally with my changes
• [ ] I have added new tests that prove my fix is effective or that my feature works
• [ ] I have added necessary documentation

[codecov[bot]]

Codecov Report

Merging #56 (cbc4282) into master (39e4a0d) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   76.37%   76.37%           
=======================================
  Files           3        3           
  Lines         364      364           
=======================================
  Hits          278      278           
  Misses         86       86           

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 39e4a0d...cbc4282. Read the comment docs.

[anilyil]

I had not checked this before I left that previous comment. I uninstalled pyhyp now and re-installed with this branch, the "examples" package is now in pylayout, so I am guessing this fix works and @nwu63 also proves that we need to fix this in other repos as well.

Update: I am messing something up, re-installed with the master branch and I still have pylayout. its probably picking that up for some reason