Closed anilyil closed 2 years ago
Merging #65 (6d210c9) into main (f63fd7c) will decrease coverage by
0.28%
. The diff coverage is75.00%
.
@@ Coverage Diff @@
## main #65 +/- ##
==========================================
- Coverage 79.95% 79.66% -0.29%
==========================================
Files 4 4
Lines 414 418 +4
==========================================
+ Hits 331 333 +2
- Misses 83 85 +2
Impacted Files | Coverage Δ | |
---|---|---|
pyhyp/utils.py | 88.46% <75.00%> (-3.21%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
I forgot this PR was up. #66 supersedes this PR. closing.
Because the simple o cart routine is moved here from CGNS utils, I am adding the changes needed in PR: https://github.com/mdolab/cgnsutilities/pull/58 to here.
These changes let users define a custom bounding box for the simple o cart rather than just relying on the bounding box of the grid. We can also specify overset BCs on the outer faces by the optional argument
useFarfield
which defaults to farfield BCs but can be set to False to get overset BCs on the extruded o-cart.Expected time until merged
few days
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable