mdolab / pyhyp

pyHyp generates volume meshes from surface meshes using hyperbolic marching.
Other
45 stars 39 forks source link

modifications for simple o cart #65

Closed anilyil closed 2 years ago

anilyil commented 2 years ago

Because the simple o cart routine is moved here from CGNS utils, I am adding the changes needed in PR: https://github.com/mdolab/cgnsutilities/pull/58 to here.

These changes let users define a custom bounding box for the simple o cart rather than just relying on the bounding box of the grid. We can also specify overset BCs on the outer faces by the optional argument useFarfield which defaults to farfield BCs but can be set to False to get overset BCs on the extruded o-cart.

Expected time until merged

few days

Type of change

Testing

Checklist

codecov[bot] commented 2 years ago

Codecov Report

Merging #65 (6d210c9) into main (f63fd7c) will decrease coverage by 0.28%. The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   79.95%   79.66%   -0.29%     
==========================================
  Files           4        4              
  Lines         414      418       +4     
==========================================
+ Hits          331      333       +2     
- Misses         83       85       +2     
Impacted Files Coverage Δ
pyhyp/utils.py 88.46% <75.00%> (-3.21%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

anilyil commented 2 years ago

I forgot this PR was up. #66 supersedes this PR. closing.