A-CGray commented 1 year ago

Purpose

pyHyp doesn't currently work with any numpy past 1.23 (#69), this PR reflects this in the installation requirements

Expected time until merged

1 hour

Type of change

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (non-backwards-compatible fix or feature)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Documentation update
[ ] Maintenance update
[ ] Other (please describe)

Testing

Checklist

[ ] I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
[ ] I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
[ ] I have run unit and regression tests which pass locally with my changes
[ ] I have added new tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation

codecov[bot] commented 1 year ago

Codecov Report

Merging #70 (dd74b78) into main (da06bdd) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage   79.43%   79.43%           
=======================================
  Files           4        4           
  Lines         423      423           
=======================================
  Hits          336      336           
  Misses         87       87

Impacted Files	Coverage Δ
pyhyp/pyHyp.py	`76.07% <ø> (ø)`
pyhyp/__init__.py	`100.00% <100.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

A-CGray commented 1 year ago

@sseraj, Marco mentioned that pyhyp actually works with 1.23? If that's the case I'll leave it up to you whether you want to bump the required version

sseraj commented 1 year ago

Yes, pyHyp works with 1.23. I will update the PR.

marcomangano commented 1 year ago

@sseraj please go ahead and merge, I am not a maintainer.

mdolab / pyhyp