Added face normals. - Githubissues

mdolab / pyofm

Python wrapper for OpenFOAM meshes

Other

7 stars 4 forks source link

Added face normals. #1

Closed friedenhe closed 4 years ago

friedenhe commented 4 years ago

Purpose

Added the face normal as the output of stl2Foam mesh function

Type of change

What types of change is it? Select the appropriate type(s) that describe this PR

New feature (non-breaking change which adds functionality)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

[x] I have run unit and regression tests which pass locally with my changes
[ ] I have added new tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation

friedenhe commented 4 years ago

You mentioned running some tests. Would it be possible to add these to the repo?

Good question. This repo does not have its own reg tests. But it will be called in DAFoam and IDWarp's reg tests. So if those reg tests pass, it should be good. We don't have plans to add its own reg tests, it will be deprecated anyway (we will wrap DAFoam with Cython and get rid of the dependency on this repo).