search

mdolab / pyspline

pySpline produces B-spline curves, surfaces, and volumes
Other
39 stars 26 forks source link

Update testflo tests #12

Closed ewu63 closed 4 years ago

ewu63 commented 4 years ago

Purpose

I updated the testflo tests to use the new BaseRegTest API.

Type of change

What types of change is it? Select the appropriate type(s) that describe this PR

The pull request will fail because the PR in baseclasses has not been merged. I will mark this as ready for review once that is merged.

joanibal commented 4 years ago

It looks like something is going wrong with the JSON reader

    with BaseRegTest(self.ref_file, train=False) as handler:

  File "/home/mdolabuser/repos/baseclasses/baseclasses/BaseRegTest.py", line 35, in __init__

    self.db = [float(val.rstrip()) for val in file_handle.readlines()]

  File "/home/mdolabuser/repos/baseclasses/baseclasses/BaseRegTest.py", line 35, in <listcomp>

    self.db = [float(val.rstrip()) for val in file_handle.readlines()]

ValueError: could not convert string to float: '{'
ewu63 commented 4 years ago

The reason that one test failed is because that specific docker image does not contain the baseclasses PR that updated BaseRegTest, since the built bot failed last night so it didn't push the image. And the reason that image failed last night is due to unrelated issues with pyoptsparse and we can ignore it for now.

You will see that the tests for ADflow on that docker image also failed, and for the same reason.

ewu63 commented 4 years ago

The tests all pass now, after the images were re-built last night.