Adding Flake8 and Black formatting (take 2)

[bernardopacini]

Purpose

Adding Flake8 and Black formatting to all Python files in the repo (mdolab/private-docs#191). This includes the examples/, pyspline/, src/f2py/, tests/reg_tests/ directories and package setup.py as well as docs conf.py files.

Black and Flake8 disagree on how to format the setup.py file and here we stick with Black formatting.

Type of change

What types of change is it? Select the appropriate type(s) that describe this PR

• [ ] Bugfix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (non-backwards-compatible fix or feature)
• [x] Code style update (formatting, renaming)
• [ ] Refactoring (no functional changes, no API changes)
• [ ] Documentation update
• [ ] Maintenance update
• [ ] Other (please describe)

Testing

No additional tests besides the already defined regression tests.

Checklist

Put an x in the boxes that apply.

• [x] I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
• [ ] I have run unit and regression tests which pass locally with my changes
• [ ] I have added new tests that prove my fix is effective or that my feature works
• [ ] I have added necessary documentation

[bernardopacini]

For the first bullet, the import test only checks if the module can be imported, so it is entirely unused after being imported (intentionally). If I remove the import (as requested by Flake8) then this script would be useless and not actually check anything. I may be misunderstanding the purpose of this file so please correct me if I'm wrong. I'll go ahead and fix the setup.py, thank you for the heads up with that change.

For the second bullet, I double checked my black installation and it is up to date. This discrepancy may be caused by the fact that I'm running Python 3.9 on my machine, so I'll change that and make sure I'm checking for 3.7 - 3.8 instead (as Travis does).

[ewu63]

• Sorry should've been more clear. The way to address this is to add an inline comment # noqa which tells flake8 to ignore this error.
• As for black , I just tested this in a Python 3.9 environment and still getting 5 files reformatted so something is going on. Maybe we can debug this offline.

[bernardopacini]

• Got it, I missed that feature so I'll update that. Thank you for the clarification

• Very strange. I'll take a look and see why I am getting the wrong behavior on my machine. Thanks for double checking on yours, sorry for the added hassle!