Closed ewu63 closed 3 years ago
Okay I updated the following
ABS
There are other things that can be replaced by intrinsics, such as the dotproduct
subroutine, but maybe we should save that for later. A lot of our codes can be modernized though.
These new updates look good to me, but I want to wait for @eirikurj's approval before merging.
Purpose
I added the
-std=f2003
flag and fixed all the errors that came up. Since I'm on GCC 10, I also fixed the argument mismatch issue.Note that some warnings still remain:
As part of the process, I removed the
norm
function definition and replaced it by the F2008 intrinsicNORM2
. I also replaced one scalar call tonorm
with theABS
function which is equivalent for scalars.Type of change
What types of change is it? Select the appropriate type(s) that describe this PR
Testing
I updated the config file so the
-std=f95
code will be tested, but since we are on GCC 9 I guess we should just observe that the argument mismatch warnings should no longer show up in the compile log.Checklist
Put an
x
in the boxes that apply.flake8
andblack
to make sure the code adheres to PEP-8 and is consistently formatted