Fixed GCC10 + F2008 compliance

ewu63 commented 3 years ago

Purpose

I added the -std=f2003 flag and fixed all the errors that came up. Since I'm on GCC 10, I also fixed the argument mismatch issue.

Note that some warnings still remain:

parameterizations.f90:38:61:

                       (X(3, K, J, I) - X(3, K, J, I-1)) ** 2)
                                                             1
Warning: Obsolescent feature: Statement function at (1)

As part of the process, I removed the norm function definition and replaced it by the F2008 intrinsic NORM2. I also replaced one scalar call to norm with the ABS function which is equivalent for scalars.

Type of change

What types of change is it? Select the appropriate type(s) that describe this PR

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (non-backwards-compatible fix or feature)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Documentation update
[x] Maintenance update
[ ] Other (please describe)

Testing

I updated the config file so the -std=f95 code will be tested, but since we are on GCC 9 I guess we should just observe that the argument mismatch warnings should no longer show up in the compile log.

Checklist

Put an x in the boxes that apply.

[ ] I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
[x] I have run unit and regression tests which pass locally with my changes
[ ] I have added new tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation

ewu63 commented 3 years ago

Okay I updated the following

switched to F2008
reverted the subroutine name shortening
switched to using NORM2 intrinsic
replaced scalar invocation of norm with ABS

There are other things that can be replaced by intrinsics, such as the dotproduct subroutine, but maybe we should save that for later. A lot of our codes can be modernized though.

bernardopacini commented 3 years ago

These new updates look good to me, but I want to wait for @eirikurj's approval before merging.

mdolab / pyspline