Add sol time

[joanibal]

Purpose

Adds solution time as an optional parameter when writing out files to tecplot.

Adds an option to recompute the data of a volume. This is useful when looking at how the embedding volume of an FFD has changed as the points move.

It is related to this pyGeo PR

Expected time until merged

1 week

Type of change

• [ ] Bugfix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (non-backwards-compatible fix or feature)
• [ ] Code style update (formatting, renaming)
• [ ] Refactoring (no functional changes, no API changes)
• [ ] Documentation update
• [ ] Maintenance update
• [ ] Other (please describe)

Testing

Checklist

• [x] I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
• [ ] I have run unit and regression tests which pass locally with my changes
• [ ] I have added new tests that prove my fix is effective or that my feature works
• [ ] I have added necessary documentation

[codecov[bot]]

Codecov Report

Merging #40 (4c84bcf) into main (147579c) will decrease coverage by 0.03%. The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   60.55%   60.51%   -0.04%     
==========================================
  Files           5        5              
  Lines        1610     1616       +6     
==========================================
+ Hits          975      978       +3     
- Misses        635      638       +3     

Impacted Files	Coverage Δ
pyspline/utils.py	48.36% <66.66%> (+0.06%)	:arrow_up:
pyspline/pyCurve.py	51.87% <100.00%> (ø)
pyspline/pySurface.py	63.24% <100.00%> (ø)
pyspline/pyVolume.py	68.07% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[joanibal]

• The data does not get recomputed after embedding since it is only used during the embedding.

• Yeah, we probably should add the recompute arg to the the other classes too. I wish I didn't have to duplicate this code across each class, but I'm not about to restructure pyspyline.

[joanibal]

@nwu63 I have added the recompute arg to the other data types now

[joanibal]

computeData() gets the data for the Greville points on the splined object (curve, surface, or volume). These points are used to find a good initial guess for the point projection routines. When we use the splined volume for an FFD we embed many points without changing the volume. So you don't need to recompute the Greville points for each point, so pySpline saves the data and doesn't recompute it after the first call. I can't say I totally agree with the naming and how the program was implemented, but I believe that was the original thinking.

I use computeData(recompute=True) here in the related PR for pyGeo.
If you are writing the embedding volume out at each iteration, then you need to recompute the Greville points since the volume has been deformed. This way you are writing out the updated embedding volume.