akleb commented 2 years ago

Purpose

Provide an example of a cmake configure/build with an mdolab repo

Expected time until merged

A long time

Type of change

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (non-backwards-compatible fix or feature)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Documentation update
[x] Maintenance update
[x] Other (please describe)

Testing

Passing all the regression tests still and I made a new Ctest that runs the importTest.py.

Checklist

[ ] I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
[ ] I have run unit and regression tests which pass locally with my changes
[ ] I have added new tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation

codecov[bot] commented 2 years ago

Codecov Report

Merging #42 (97657d2) into main (afb9ed0) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage   60.51%   60.51%           
=======================================
  Files           5        5           
  Lines        1616     1616           
=======================================
  Hits          978      978           
  Misses        638      638

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

akleb commented 2 years ago

The TACC image will continually fail since it does not have cmake >= 3.12

ewu63 commented 2 years ago

I'm going to close this PR but keep the branch open in case we want to get back to it.

mdolab / pyspline