mdolab / pyspline

pySpline produces B-spline curves, surfaces, and volumes

Other

39 stars 26 forks source link

Update library import check #50

Closed eirikurj closed 2 years ago

eirikurj commented 2 years ago

Purpose

Currently, the library import check suppresses useful information why the library could not be imported. This PR updates the import check to print out the full error message.

Expected time until merged

No rush

Type of change

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (non-backwards-compatible fix or feature)
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no API changes)
[ ] Documentation update
[ ] Maintenance update
[ ] Other (please describe)

Testing

Compile the module with and without the fix, with a broken library

Checklist

[x] I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
[ ] I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
[ ] I have run unit and regression tests which pass locally with my changes
[ ] I have added new tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation

codecov[bot] commented 2 years ago

Codecov Report

Merging #50 (fca4dc7) into main (25535b8) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   52.53%   52.53%           
=======================================
  Files           5        5           
  Lines        1616     1616           
=======================================
  Hits          849      849           
  Misses        767      767

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more