mdolab / pyspline

pySpline produces B-spline curves, surfaces, and volumes
Other
39 stars 26 forks source link

Change `linalg.dsolve.factorized` to `linalg.factorized` #53

Closed A-CGray closed 1 year ago

A-CGray commented 1 year ago

Purpose

SciPy has started producing the following deprecation warnings when running pySpline:

DeprecationWarning: Please use `factorized` from the `scipy.sparse.linalg` namespace, the `scipy.sparse.linalg.eigen` namespace is deprecated.

This PR updates where we get the factorized function from to fix this. I checked, and the factorized function is available in the new location in scipy 1.5.4 which is the oldest version we currently we support.

Expected time until merged

1 day

Type of change

Testing

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #53 (2304674) into main (0c78591) will not change coverage. The diff coverage is 42.85%.

@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   52.53%   52.53%           
=======================================
  Files           5        5           
  Lines        1616     1616           
=======================================
  Hits          849      849           
  Misses        767      767           
Impacted Files Coverage Δ
pyspline/pyVolume.py 40.80% <0.00%> (ø)
pyspline/pySurface.py 63.24% <50.00%> (ø)
pyspline/pyCurve.py 51.87% <66.66%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more