mdolab / pyspline

pySpline produces B-spline curves, surfaces, and volumes
Other
39 stars 26 forks source link

Specified tolerances in assert_allclose calls #60

Closed sseraj closed 1 year ago

sseraj commented 1 year ago

Purpose

After updating the latest NumPy version to 1.25.2 (mdolab/docker#233), some of the tests fail marginally on Azure (see logs here).

The problem is that some of the assert_allclose calls are using the default atol=0 and there are some values in the arrays that are not exactly zero but less than 1e-15. I added atol=1e-15 to these calls to fix this. I also added rtol=1e-7, which is the default, for clarity.

Expected time until merged

Type of change

Testing

Current tests should pass on Azure

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #60 (ff83296) into main (4cba2aa) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #60   +/-   ##
=======================================
  Coverage   52.53%   52.53%           
=======================================
  Files           5        5           
  Lines        1616     1616           
=======================================
  Hits          849      849           
  Misses        767      767           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more