search

mdolab / pyspline

pySpline produces B-spline curves, surfaces, and volumes
Other
39 stars 26 forks source link

Number of control points option has incorrect capitalization in examples #68

Closed eytanadler closed 8 months ago

eytanadler commented 9 months ago

Description

In all examples, the number of control points option is given as Nctl, when I think it is meant to be nCtl. These values then have no impact on the results. I'm happy to correct this, but wanted to make sure I wasn't being dumb before doing so.

Steps to reproduce issue

  1. Look at the examples
  2. Look at the source code
  3. Notice that they don't match
eirikurj commented 9 months ago

I am not surprised. One of the reasons to prefer explicit interfaces or at minimum pop and check the remaining kwargs.