sseraj commented 2 years ago

Purpose

I cleaned up the imports and dependencies, including adding SciPy as a requirement and removing a deprecated convert function that was importing pyGeo.

Expected time until merged

Regular urgency; one week

Type of change

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (non-backwards-compatible fix or feature)
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no API changes)
[ ] Documentation update
[x] Maintenance update
[ ] Other (please describe)

Testing

Checklist

[x] I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
[x] I have run unit and regression tests which pass locally with my changes
[ ] I have added new tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation

codecov[bot] commented 2 years ago

Codecov Report

Merging #12 (20f44f4) into main (07bb6ec) will increase coverage by 1.82%. The diff coverage is 23.33%.

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   46.97%   48.79%   +1.82%     
==========================================
  Files           5        5              
  Lines        1816     1744      -72     
==========================================
- Hits          853      851       -2     
+ Misses        963      893      -70

Impacted Files	Coverage Δ
pysurf/tecplot_interface.py	`7.51% <0.00%> (+1.84%)`	:arrow_up:
pysurf/tsurf_tools.py	`48.91% <13.63%> (+0.62%)`	:arrow_up:
pysurf/tsurf_component.py	`60.72% <100.00%> (+0.02%)`	:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more