mdolab / pysurf

pySurf provides geometric operations for triangulated surfaces.
Apache License 2.0
2 stars 4 forks source link

Minor adjustment to make, exit when error #18

Closed eirikurj closed 2 years ago

eirikurj commented 2 years ago

Purpose

Even thought there was an error on the real, the build proceeded to the complex build. The maked the real problem as the real stdout error is far away. This PR changes that by exiting if the real build fails.

Expected time until merged

No rush

Type of change

Testing

Checklist

codecov[bot] commented 2 years ago

Codecov Report

Merging #18 (cc9cbb1) into main (56789f9) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #18   +/-   ##
=======================================
  Coverage   49.97%   49.97%           
=======================================
  Files           5        5           
  Lines        1683     1683           
=======================================
  Hits          841      841           
  Misses        842      842           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

eirikurj commented 2 years ago

@sseraj not really an issue, but currently, both the real and complex libraries are built when issuing make. Was this done out of convenience or? Just thinking if we should split this up similar to what we do in other repos? Then we would have build/test_complex.sh scripts.