Closed eirikurj closed 2 years ago
Merging #22 (9edb26f) into main (3f2f060) will not change coverage. The diff coverage is
n/a
.:exclamation: Current head 9edb26f differs from pull request most recent head 0eb909d. Consider uploading reports for the commit 0eb909d to get more accurate results
@@ Coverage Diff @@
## main #22 +/- ##
=======================================
Coverage 49.97% 49.97%
=======================================
Files 5 5
Lines 1683 1683
=======================================
Hits 841 841
Misses 842 842
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Purpose
I find the failing of
make clean
a little strange if the*.so
have been deleted (e.g., by an earliermake clean
) or are not found (have been moved by an external process). All other generated files are cleaned or fail silently if they do not exist.This PR will make the behavior consistent when cleaning all generated files, including
*.so
files.Expected time until merged
No rush.
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable