Closed sseraj closed 2 years ago
Merging #8 (f6e3e02) into master (58929b9) will not change coverage. The diff coverage is
n/a
.:exclamation: Current head f6e3e02 differs from pull request most recent head fadb634. Consider uploading reports for the commit fadb634 to get more accurate results
@@ Coverage Diff @@
## master #8 +/- ##
=======================================
Coverage 46.97% 46.97%
=======================================
Files 5 5
Lines 1816 1816
=======================================
Hits 853 853
Misses 963 963
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 58929b9...fadb634. Read the comment docs.
I think maybe we should keep the one the print out 'Geometry objects do not overlap.' in the
computeIntersection
? What do you think?
That's a good point. I grepped my log files and didn't find any instances of this statement so it probably only shows up when something is wrong. I uncommented this in computeIntersection
as well.
Purpose
I commented out some print statements in intersectionAPI that were making the output hard to read. These look like debug statements because the same lines were already commented in
computeIntersection
but not in the differentiated routines.Type of change
Testing
Checklist
flake8
andblack
to make sure the code adheres to PEP-8 and is consistently formatted