Fix survol container getting out of screen (height)

mdolr / survol

A browser extension to preview any link you hover

https://survol.me

Apache License 2.0

143 stars 67 forks source link

Fix survol container getting out of screen (height) #96

Open mdolr opened 4 years ago

mdolr commented 4 years ago

Make sure the content always fits on the screen, here are various things that could be done :

Set a max height
Limit the size of the content (for example: only display X words in the preview)

This has to be done as sometimes the container is below the cursor but because there is not enough space its position is changed to above the cursor even though it doesn't fit too.

The container positionning logic is situated in js/core.js in the mousemove event.

rezziemaven commented 4 years ago

Hi @mdolr! I'd love to work on this. Would you mind assigning it to me?

rezziemaven commented 4 years ago

Hey @mdolr, just letting you know I'm almost done with this one, but just trying to fix one thing with my code that's causing a styling issue before I submit.

rezziemaven commented 4 years ago

Hi @mdolr! Just submitted a PR to address this issue: see #146.