search

mdomke / concourse-email-resource

A simple email resource for concourse CI
MIT License
3 stars 13 forks source link

subject_text and body_text variables #7

Open knifhen opened 7 years ago

knifhen commented 7 years ago

I found that the way I used to do variable substitution before is no longer valid. I have added to source params variable_start_string and variable_end_string that can be used to avoid the conflict between concourse and jinja variable substitution by configuring jinja to use another start and end token such as {( )} instead of {{ }}

I have updated the documentation accordingly.

Solves #6

knifhen commented 7 years ago

Hey, any chance this might get merged? Best Regards, Andreas

mdomke commented 7 years ago

I think we can merge this, but on the other hand the parameter delimiter in concourse has been changed to ((parameter)). See here. Would you still need your feature under these circumstances?

knifhen commented 7 years ago

That depends on when concourse will remove the old syntax entirely, at the moment I think they are keeping it around for backwards compatibility. However, I'm trying out my changes and I'm running into troubles with the jinja not parsing my templates correctly, so for now hold of on merging. I'll get back to you when I'm done debugging.

Regards Andreas

On Thu, 22 Jun 2017 at 09:47 Martin Domke notifications@github.com wrote:

I think we can merge this, but on the other hand the parameter delimiter in concourse has been changed to ((parameter)). See here https://concourse.ci/fly-set-pipeline.html#parameters. Would you still need your feature under these circumstances?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mdomke/concourse-email-resource/pull/7#issuecomment-310303206, or mute the thread https://github.com/notifications/unsubscribe-auth/AAC8tIKFMWWhWibnVkQv2NYvobjgd7Jsks5sGhwSgaJpZM4MqM5S .

knifhen commented 7 years ago

I found my problem, a typo in my pipeline. So there was nothing wrong with the code changes in the pullrequest. So I think it would be a good idea to merge the pull request.

Best Regards Andreas

On Thu, 22 Jun 2017 at 09:53 Andreas Knifh andreas.knifh@gmail.com wrote:

That depends on when concourse will remove the old syntax entirely, at the moment I think they are keeping it around for backwards compatibility. However, I'm trying out my changes and I'm running into troubles with the jinja not parsing my templates correctly, so for now hold of on merging. I'll get back to you when I'm done debugging.

Regards Andreas

On Thu, 22 Jun 2017 at 09:47 Martin Domke notifications@github.com wrote:

I think we can merge this, but on the other hand the parameter delimiter in concourse has been changed to ((parameter)). See here https://concourse.ci/fly-set-pipeline.html#parameters. Would you still need your feature under these circumstances?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mdomke/concourse-email-resource/pull/7#issuecomment-310303206, or mute the thread https://github.com/notifications/unsubscribe-auth/AAC8tIKFMWWhWibnVkQv2NYvobjgd7Jsks5sGhwSgaJpZM4MqM5S .