search

mdomke / python-ulid

ULID implementation for Python
https://python-ulid.rtfd.io
MIT License
412 stars 19 forks source link

fix: ensure the timestamp validation checks the upper limit given in the `ulid` spec #27

Closed somnam closed 4 months ago

somnam commented 4 months ago

https://github.com/mdomke/python-ulid/issues/26#issuecomment-2171789400

Based on a similar approach in ulid-py

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.61%. Comparing base (419116f) to head (0b82942).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #27 +/- ## ========================================== - Coverage 99.61% 99.61% -0.01% ========================================== Files 4 4 Lines 262 259 -3 Branches 66 66 ========================================== - Hits 261 258 -3 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mdomke commented 4 months ago

@somnam thank you very much! I guess I was too much focused on creating ULIDs with legit datetime values, so that I didn't pay enough attention to the specification.

somnam commented 4 months ago

@somnam thank you very much!

Thanks a lot for the merge and quick release!