[libsf] fix empty items sending and session expiration parsing

mdouchement / standardfile

Yet Another Standardfile (standardnotes server) Implementation written in Golang

MIT License

79 stars 9 forks source link

[libsf] fix empty items sending and session expiration parsing #50

Closed cherya closed 3 years ago

cherya commented 3 years ago

I'm using libsf with official syncing-server and having some issues with it:

empty items field on first sync causes empty sync response
session endpoints returns time in unix format instead of RFC3339

solutions:

omitempty request fields
unmarshal both unix and RFC3339 time formats

I'm not sure about necessity of it maybe I should create issue to discuss first :)

mdouchement commented 3 years ago

You're right both syncing-server and syncing-server-js use millisecond unix timestamps. I written libsf in order to use this standardfile server and ensured to avoid any conflicts with the snjs library but I haven't tested on the syncing-server implementation.