Issue with session refresh

[mdouchement]

Refreshing the session
Error: could not refresh session: Invalid login credentials.

[mdouchement]

StandardNotes behavior have changed.

[mdouchement]

Qccording to the doc: https://docs.standardnotes.com/specification/auth/#refreshing-tokens

• The middleware should return the following result in order to trigg a refresh:

  498 Expired Access Token
  {
  "error": {
    "tag": "expired-access-token",
    "message": "The provided access token has expired."
  }
  }

• Source code: https://github.com/standardnotes/auth/blob/develop/src/Domain/UseCase/RefreshSessionToken.ts

[mdouchement]

Qccording to the doc, refresh token process have really changed:

POST /session/token/refresh HTTP/1.1
Host: sync.standardnotes.org
Authorization: Bearer <access token>

{
  "refresh_token": "R_xxxxxxx-xxxx-Mxxx-Nxxx-xxxxxxxxxxxx"
}

200 OK
{
  "token": "xxxxxxx-xxxx-Mxxx-Nxxx-xxxxxxxxxxxx",
  "session": {
    "refresh_expiration": 1583020800,
    "refresh_token": "xxxxxxx-xxxx-Mxxx-Nxxx-xxxxxxxxxxxx",
  }
}

• The path at least chenged from /session/refresh to /session/token/refresh
  • But the source code declares the /session/refresh ...
  • https://github.com/standardnotes/auth/blob/develop/src/Controller/SessionController.ts#L100

Source code client session management https://github.com/standardnotes/snjs/tree/master/packages/snjs/lib/Services/Session

[valantur]

thanks for staying on top of this!

[mdouchement]

Fixed 🎉