search

mdp / MachinePoker

Gambling.js
74 stars 26 forks source link

bots able to act after folding #5

Closed chanian closed 12 years ago

chanian commented 12 years ago

.play() still being invoked on each street even after bot has folded. This allows players to act / bet even though they are no longer in the hand. additionally, this reports false actions which can throw off overall player actions for a hand.

// see the logged complete game results for foldBot.js { name: 'foldBot1', blind: 5, ante: 0, wagered: 0, state: 'folded', chips: 990, actions: { 'pre-flop': [ { type: 'fold' } ], flop: [ { type: 'fold' } ], turn: [ { type: 'fold' } ], river: [ { type: 'fold' } ] }, payout: -10 }

mdp commented 12 years ago

This seems to be a bug in the Binions library, I'll hunt it down tonight.

mdp commented 12 years ago

Fixed/Tests added mdp/binions@13c29cf928925a9d8f4928eede053aef92d90b52. Pull the latest MachinePoker and run npm install

Thanks for catching this. Basically if you were the first position to act(small blind), you'd always be given the chance to bet regardless of state.