search

mdp / qrterminal

QR Codes in your terminal
MIT License
442 stars 53 forks source link

Use Unicode half blocks #4

Closed viric closed 6 years ago

viric commented 6 years ago

Here is a proposal implementation. It makes the config more complicated though.

mdp commented 6 years ago

This looks like a great idea. I made some changes so it won't break the existing API. Also, what do you think about trying to use the quadrant block elements (U+2596 to U+259F, plus top and bottom half and full block)? You should be able to get even more compression this way.

viric commented 6 years ago

That may work, yes, but notice that using quadrants might require playing with foreground and background colours.

I tried to get code to work both in dark background and light background terminals, but I failed to.

Feel free to change all you like. :)

On Tue, Dec 19, 2017 at 11:01:02AM -0800, Mark Percival wrote:

This looks like a great idea. I made some changes so it won't break the existing API. Also, what do you think about trying to use the quadrant block elements (U+2596 to U+259F, plus top and bottom half and full block)? You should be able to get even more compression this way.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/mdp/qrterminal/pull/4#issuecomment-352854177

-- (Escriu-me xifrat si saps PGP / Write ciphered if you know PGP) PGP key 7CBD1DA5 - https://emailselfdefense.fsf.org/

mdp commented 6 years ago

Yeah, I played with it, and the issue I ran into was that quadrants "stretch" out the QR code vertically, so it's no longer square. I'll merge your half block changes later today and update the README.

Thanks for this, it's a really useful addition.

mdp commented 6 years ago

Merged and updated the docs. Thanks for adding this.