search

mdp / qrterminal

QR Codes in your terminal
MIT License
442 stars 53 forks source link

qr codes need 3 more pixels of border #5

Closed rsc closed 6 years ago

rsc commented 6 years ago

Very nice project. I just wanted to point out that the QR spec says that the code itself must be placed in a 4-pixel-wide white border or "quiet zone", to help scanning software locate the code in a larger picture. The example on your front page only has a 1-pixel border, which may not be enough for some readers.

The most costly example I know of this bug is https://www.facebook.com/notes/facebook-engineering/a-hack-of-epic-proportions-building-a-qr-code-on-the-roof/10150630641218920/, in which Facebook engineers put a QR code on the roof of their new building. Unfortunately they did not include enough white border around the code, with the result that many readers I tried back in 2012 could not recognize the code in the image.

mdp commented 6 years ago

Thanks for pointing this out, it's something I hadn't realized when I ported it over from node. I'll add the ability to expand the quiet zone and match it up with the QR spec.

Thanks

mdp commented 6 years ago

Fixed and out in v1.0.0. Thanks